Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

alloc: align with AllocRef trait changes in nightly #1

Merged
merged 1 commit into from
Oct 1, 2020
Merged

alloc: align with AllocRef trait changes in nightly #1

merged 1 commit into from
Oct 1, 2020

Conversation

al3xtjames
Copy link
Contributor

Needed since rust-lang/rust#76993

Signed-off-by: Alex James theracermaster@gmail.com

@al3xtjames
alloc: align with AllocRef trait changes in nightly
42e787d 
Needed since rust-lang/rust#76993

Signed-off-by: Alex James <theracermaster@gmail.com>
@dvdhrm
Copy link
Member

dvdhrm commented Oct 1, 2020

Thank you very much! I saw the CI failures since the start of the week, but didn't look into it, yet.

I sometimes wonder whether we should remove the AllocRef implementation until it is stable. We could just map GlobalAlloc directly and avoid the redirection via AllocRef. But I guess at the same time it is kinda nice to give the unstable interface some testing and see whether it fulfils our needs.

Anyway, thanks a lot!

@dvdhrm dvdhrm merged commit 58c7085 into r-efi:master Oct 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@al3xtjames @dvdhrm